Skip to content

Conversation

@Solant
Copy link
Contributor

@Solant Solant commented Apr 19, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixed incorrect property description

Breaking Changes

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Apr 19, 2019

CLA assistant check
All committers have signed the CLA.

@alexander-akait
Copy link
Member

Thanks for PR, please accept CLA

@Solant
Copy link
Contributor Author

Solant commented Apr 19, 2019

@evilebottnawi done, there is a npm audit issue, should I resolve it?

@alexander-akait
Copy link
Member

@Solant if you do this, will be great, just update lock file 👍

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #923 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          10       10           
  Lines         395      395           
  Branches      119      119           
=======================================
  Hits          392      392           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a0a3c...24493db. Read the comment docs.

@alexander-akait alexander-akait merged commit 0b8362c into webpack:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants