-
-
Notifications
You must be signed in to change notification settings - Fork 392
feat(index): allow filename to be a {Function} (options.filename)
#225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
85f6eda
feat: allow filename to be a function
berthertogen 52cf7f6
feat: update tests
berthertogen cf7b731
feat: remove throw and change isFunction
berthertogen a06f5df
feat: pass correct chunk
berthertogen 835624c
feat: fix test and names
berthertogen 44cd88f
feat: remove console.log's
berthertogen 5b45d7e
Filename as a function - Added to README.md, Clean up as per feedback…
owlyowl 6012a49
Corrections to try catch wrapping as suggested by @ooflorent
owlyowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: fix test and names
- Loading branch information
commit 835624c0e91d0362778a2d897f3cac64ab57dbc2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,8 +18,8 @@ module.exports = { | |
| }, | ||
| plugins: [ | ||
| new Self({ | ||
| filename: (data) => data.chunk.name == 'app' ? 'this.is.app.css' : `[name].css`, | ||
| chunkFilename: (data) => '[name].css', | ||
| filename: (chunk) => chunk.name == 'app' ? 'this.is.app.css' : `[name].css`, | ||
| chunkFilename: (chunk) => '[name].css', | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. chunkFilename can't be a function |
||
| }), | ||
| ], | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed