Skip to content

fix(index): loading order mismatch #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 5 commits into from
Aug 14, 2018
Merged

fix(index): loading order mismatch #236

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
856da5e
fix css files load order mismatch #188
ShanaMaid Aug 8, 2018
a4eb222
fix(src): fix sort bug
ShanaMaid Aug 9, 2018
b990ee0
feat(test): add test
ShanaMaid Aug 9, 2018
7f19065
test(sorting): add test case which uses the fallback behavior
sokra Aug 13, 2018
a16d240
fix(sorting): revert change to restore original behavior
sokra Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(sorting): revert change to restore original behavior 
This fixes the testcase
  • Loading branch information
@sokra
sokra committed Aug 13, 2018
commit a16d24087543923a6aa9e4bdddd9e32a0785e363
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ class MiniCssExtractPlugin {
// (to avoid a breaking change)
// TODO remove this in next mayor version
// and increase minimum webpack version to 4.12.0
modules.sort((a, b) => b.index2 - a.index2);
modules.sort((a, b) => a.index2 - b.index2);
}
const source = new ConcatSource();
const externalsSource = new ConcatSource();
Expand Down