Remove unnecessary setting of filename and chunkFilename in devMode #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the example don't use the plugin in devMode at all, there is no reason to have a special filename configuration for the devMode.
|
|
alexander-akait
requested changes
Nov 23, 2018
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Some people this in development mode
Member
|
It is good practice have configuration in examples for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the example don't use the plugin in devMode at all, there is no reason to have a special filename configuration for the devMode.
This PR contains a:
Motivation / Use-Case
The example may confuse users, or they use things in their config which are not required, just like me, before I've realized that it doesn't make sense.