Skip to content

fix: friendly description of vague error #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hinell wants to merge 2 commits into from
Closed

fix: friendly description of vague error #363

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ad4bb
fix: friendly description of vague error
hinell Mar 14, 2019
06549a9
Merge branch 'master' into master
evilebottnawi Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: friendly description of vague error 
After all these years we have an opportunity to enjoy
a human-friendly error description...
  • Loading branch information
@hinell
hinell committed Mar 15, 2019
commit 51ad4bb9f1470aa03ce64f709e0eff03e1692c7a
8 changes: 7 additions & 1 deletion src/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,13 @@ export function pitch(request) {
};
});
}
this[MODULE_TYPE](text);
try {
this[MODULE_TYPE](text);
} catch (error) {
const pluginIsNotFound = `Invalid webpack configuration: plugin ${pluginName} is not found.
It's highly likely that you forgot to add css extraction plugin into your webpack configuration(s)`;
throw new Error(pluginIsNotFound);
}
} catch (e) {
return callback(e);
}
Expand Down