Skip to content

Remove empty modules #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
irudoy wants to merge 11 commits into from
Closed

Remove empty modules #380

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
84782d4
fix: remove empty modules
irudoy Apr 10, 2019
36c1456
fix: use `for of` instead of `forEach` for `modulesIterable`
irudoy May 31, 2019
55c959a
fix: add cjs test case
irudoy May 31, 2019
218a135
test: add manual stress test
irudoy Jun 3, 2019
bec4a2b
fix: avoid using issuer
irudoy Jun 3, 2019
1a26dca
fix: skip cjs when removing empty modules, refactor
irudoy Jul 31, 2019
ba37daa
fix: add test/stress to .prettierignore
irudoy Jul 31, 2019
634784e
fix: css formatting
irudoy Jul 31, 2019
ee6be12
fix: improve SetMap
irudoy Oct 3, 2019
c70f4e3
fix: check CommonJS
irudoy Oct 3, 2019
396cba7
fix: add allowlist for supported dependencies
irudoy Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: avoid using issuer
  • Loading branch information
@irudoy
irudoy committed Feb 19, 2020
commit bec4a2be41cb335c6d63f55135bb5fd8e0c97bee
12 changes: 6 additions & 6 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,12 @@ class MiniCssExtractPlugin {
return true;
});

if (
module.type === MODULE_TYPE &&
module.issuer &&
module.issuer.buildMeta.extracted
) {
chunk.removeModule(module.issuer);
if (module.type === MODULE_TYPE && module.reasons) {
for (const reason of module.reasons) {
if (reason.module && reason.module.buildMeta.extracted) {
chunk.removeModule(reason.module);
}
}
}
}
}
Expand Down