Skip to content

fix(loader): fix publicPath regression #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 5 commits into from
May 14, 2019
Merged

fix(loader): fix publicPath regression #384

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c789fb
fix(loader): fix publicPath regression
rmja Apr 25, 2019
0b4c737
test(loader): Add test for the case when publicPath is an empty string
rmja Apr 26, 2019
8ae0739
Revert "test(loader): Add test for the case when publicPath is an emp…
rmja Apr 26, 2019
85643bb
test(loader): Add test for the case when publicPath is an empty string
rmja Apr 26, 2019
c996d15
Merge branch 'master' into patch-2
evilebottnawi May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(loader): fix publicPath regression 
... when the publicPath is set to an empty string. The publicPath should resolve to an empty string in this case and _not_ `/`
  • Loading branch information
@rmja
rmja authored Apr 25, 2019
commit 1c789fb2383d8c23e02ce103c75905833249edd2
2 changes: 1 addition & 1 deletion src/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function pitch(request) {
const childFilename = '*'; // eslint-disable-line no-path-concat
const publicPath =
typeof options.publicPath === 'string'
? options.publicPath.endsWith('/')
? options.publicPath === '' || options.publicPath.endsWith('/')
? options.publicPath
: `${options.publicPath}/`
: typeof options.publicPath === 'function'
Expand Down