Skip to content

Conversation

@fengzilong
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

related issue: #413

support customizing attributes for link tag

Breaking Changes

No

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Jun 26, 2019

CLA assistant check
All committers have signed the CLA.

@fengzilong
Copy link
Author

fengzilong commented Jul 8, 2019

Any review please?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove yarn.lock, also it think it should be done using hooks, it is allow other plugins change attributes

@fengzilong
Copy link
Author

Thanks for reply, I'll look into the hooks implementation

@dutzi
Copy link

dutzi commented Aug 15, 2019

Any updates regarding this PR?

Our use case: we're using css-vars-ponyfill for IE11, we are a widget embedded in a website, we want css-vars-ponyfill to run only on CSS generated by us.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@dutzi
Copy link

dutzi commented Aug 17, 2019

Hey @evilebottnawi, I tried looking at the test/cases directory for reference as to how I can write a test for such feature, but I couldn't find anything that resembles this setup. In this test we are required to test for the code generated by this block, but what file does it output? What would I put in the expected folder

Can you please provide some guidance?

@alexander-akait
Copy link
Member

Close in favor #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants