-
-
Notifications
You must be signed in to change notification settings - Fork 390
feat: add attrs option #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any review please? |
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove yarn.lock, also it think it should be done using hooks, it is allow other plugins change attributes
|
Thanks for reply, I'll look into the hooks implementation |
|
Any updates regarding this PR? Our use case: we're using css-vars-ponyfill for IE11, we are a widget embedded in a website, we want css-vars-ponyfill to run only on CSS generated by us. |
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests
|
Hey @evilebottnawi, I tried looking at the Can you please provide some guidance? |
|
Close in favor #445 |
This PR contains a:
Motivation / Use-Case
related issue: #413
support customizing attributes for link tag
Breaking Changes
No
Additional Info