feat: ability to disable extract modules, less code difference

src/loader.js

@@ -69,133 +69,134 @@ export function pitch(request) {
 
   if (this[`${MODULE_TYPE}/disableExtract`]()) {
     callback();
-  } else {
-    const childFilename = '*'; // eslint-disable-line no-path-concat
-    const publicPath =
-      typeof options.publicPath === 'string'
-        ? options.publicPath === '' || options.publicPath.endsWith('/')
-          ? options.publicPath
-          : `${options.publicPath}/`
-        : typeof options.publicPath === 'function'
-        ? options.publicPath(this.resourcePath, this.rootContext)
-        : this._compilation.outputOptions.publicPath;
-    const outputOptions = {
-      filename: childFilename,
-      publicPath,
-    };
-    const childCompiler = this._compilation.createChildCompiler(
-      `${pluginName} ${request}`,
-      outputOptions
-    );
-
-    new NodeTemplatePlugin(outputOptions).apply(childCompiler);
-    new LibraryTemplatePlugin(null, 'commonjs2').apply(childCompiler);
-    new NodeTargetPlugin().apply(childCompiler);
-    new SingleEntryPlugin(this.context, `!!${request}`, pluginName).apply(
-      childCompiler
-    );
-    new LimitChunkCountPlugin({ maxChunks: 1 }).apply(childCompiler);
-
-    // We set loaderContext[MODULE_TYPE] = false to indicate we already in
-    // a child compiler so we don't spawn another child compilers from there.
-    childCompiler.hooks.thisCompilation.tap(
-      `${pluginName} loader`,
-      (compilation) => {
-        compilation.hooks.normalModuleLoader.tap(
-          `${pluginName} loader`,
-          (loaderContext, module) => {
+    return;
+  }
+
+  const childFilename = '*'; // eslint-disable-line no-path-concat
+  const publicPath =
+    typeof options.publicPath === 'string'
+      ? options.publicPath === '' || options.publicPath.endsWith('/')
+        ? options.publicPath
+        : `${options.publicPath}/`
+      : typeof options.publicPath === 'function'
+      ? options.publicPath(this.resourcePath, this.rootContext)
+      : this._compilation.outputOptions.publicPath;
+  const outputOptions = {
+    filename: childFilename,
+    publicPath,
+  };
+  const childCompiler = this._compilation.createChildCompiler(
+    `${pluginName} ${request}`,
+    outputOptions
+  );
+
+  new NodeTemplatePlugin(outputOptions).apply(childCompiler);
+  new LibraryTemplatePlugin(null, 'commonjs2').apply(childCompiler);
+  new NodeTargetPlugin().apply(childCompiler);
+  new SingleEntryPlugin(this.context, `!!${request}`, pluginName).apply(
+    childCompiler
+  );
+  new LimitChunkCountPlugin({ maxChunks: 1 }).apply(childCompiler);
+
+  // We set loaderContext[MODULE_TYPE] = false to indicate we already in
+  // a child compiler so we don't spawn another child compilers from there.
+  childCompiler.hooks.thisCompilation.tap(
+    `${pluginName} loader`,
+    (compilation) => {
+      compilation.hooks.normalModuleLoader.tap(
+        `${pluginName} loader`,
+        (loaderContext, module) => {
+          // eslint-disable-next-line no-param-reassign
+          loaderContext.emitFile = this.emitFile;
+          loaderContext[MODULE_TYPE] = false; // eslint-disable-line no-param-reassign
+
+          if (module.request === request) {
             // eslint-disable-next-line no-param-reassign
-            loaderContext.emitFile = this.emitFile;
-            loaderContext[MODULE_TYPE] = false; // eslint-disable-line no-param-reassign
-
-            if (module.request === request) {
-              // eslint-disable-next-line no-param-reassign
-              module.loaders = loaders.map((loader) => {
-                return {
-                  loader: loader.path,
-                  options: loader.options,
-                  ident: loader.ident,
-                };
-              });
-            }
+            module.loaders = loaders.map((loader) => {
+              return {
+                loader: loader.path,
+                options: loader.options,
+                ident: loader.ident,
+              };
+            });
           }
-        );
-      }
-    );
+        }
+      );
+    }
+  );
 
-    let source;
+  let source;
 
-    childCompiler.hooks.afterCompile.tap(pluginName, (compilation) => {
-      source =
-        compilation.assets[childFilename] &&
-        compilation.assets[childFilename].source();
+  childCompiler.hooks.afterCompile.tap(pluginName, (compilation) => {
+    source =
+      compilation.assets[childFilename] &&
+      compilation.assets[childFilename].source();
 
-      // Remove all chunk assets
-      compilation.chunks.forEach((chunk) => {
-        chunk.files.forEach((file) => {
-          delete compilation.assets[file]; // eslint-disable-line no-param-reassign
-        });
+    // Remove all chunk assets
+    compilation.chunks.forEach((chunk) => {
+      chunk.files.forEach((file) => {
+        delete compilation.assets[file]; // eslint-disable-line no-param-reassign
       });
     });
+  });
 
-    childCompiler.runAsChild((err, entries, compilation) => {
-      if (err) {
-        return callback(err);
-      }
+  childCompiler.runAsChild((err, entries, compilation) => {
+    if (err) {
+      return callback(err);
+    }
 
-      if (compilation.errors.length > 0) {
-        return callback(compilation.errors[0]);
-      }
+    if (compilation.errors.length > 0) {
+      return callback(compilation.errors[0]);
+    }
 
-      compilation.fileDependencies.forEach((dep) => {
-        this.addDependency(dep);
-      }, this);
+    compilation.fileDependencies.forEach((dep) => {
+      this.addDependency(dep);
+    }, this);
 
-      compilation.contextDependencies.forEach((dep) => {
-        this.addContextDependency(dep);
-      }, this);
+    compilation.contextDependencies.forEach((dep) => {
+      this.addContextDependency(dep);
+    }, this);
 
-      if (!source) {
-        return callback(new Error("Didn't get a result from child compiler"));
-      }
+    if (!source) {
+      return callback(new Error("Didn't get a result from child compiler"));
+    }
 
-      let text;
-      let locals;
-
-      try {
-        text = exec(this, source, request);
-        locals = text && text.locals;
-        if (!Array.isArray(text)) {
-          text = [[null, text]];
-        } else {
-          text = text.map((line) => {
-            const module = findModuleById(compilation.modules, line[0]);
-
-            return {
-              identifier: module.identifier(),
-              content: line[1],
-              media: line[2],
-              sourceMap: line[3],
-            };
-          });
-        }
-        this[MODULE_TYPE](text);
-      } catch (e) {
-        return callback(e);
+    let text;
+    let locals;
+
+    try {
+      text = exec(this, source, request);
+      locals = text && text.locals;
+      if (!Array.isArray(text)) {
+        text = [[null, text]];
+      } else {
+        text = text.map((line) => {
+          const module = findModuleById(compilation.modules, line[0]);
+
+          return {
+            identifier: module.identifier(),
+            content: line[1],
+            media: line[2],
+            sourceMap: line[3],
+          };
+        });
       }
+      this[MODULE_TYPE](text);
+    } catch (e) {
+      return callback(e);
+    }
 
-      let resultSource = `// extracted by ${pluginName}`;
-      const result = locals
-        ? `\nmodule.exports = ${JSON.stringify(locals)};`
-        : '';
+    let resultSource = `// extracted by ${pluginName}`;
+    const result = locals
+      ? `\nmodule.exports = ${JSON.stringify(locals)};`
+      : '';
 
-      resultSource += options.hmr
-        ? hotLoader(result, { context: this.context, options, locals })
-        : result;
+    resultSource += options.hmr
+      ? hotLoader(result, { context: this.context, options, locals })
+      : result;
 
-      return callback(null, resultSource);
-    });
-  }
+    return callback(null, resultSource);
+  });
 }
 
 export default function(source) {