Add support of ngupgrade #443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 4 4
Lines 411 411
Branches 86 86
=======================================
Hits 363 363
Misses 46 46
Partials 2 2
Continue to review full report at Codecov.
|
Update result of the test due to the modification of loader.js
alexander-akait
requested changes
Aug 26, 2019
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Please add tests or provide minimum reproducible test repo
Member
|
No need, it is js file where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Allows the use of the plugin in a context ngupgrade (angularJs with Angular)
Breaking Changes
just a modification of a comment // in /* comment */
Additional Info