feat(settings): support chunkFilename as function #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Lately we split our webpack build in different processes.
So
mini-css-extract-pluginwas creating chunks named1.min.cssfor different modules in each builds, overwriting the chunk from other builds. It just wasn't configured to add the hash to the name.We configured it to add the hash to the name using the
chunkFilenamesetting.But, it named our
common.min.cssbundle as a chunk making itcommon.<hash>.min.css.The issue is that we load this file explicitly in our templates, so we couldn't predict the new name.
A solution was to use a function for
chunkFilename, just like webpack's configurations. But this plugin didn't support functions for this setting.Breaking Changes
Not breaking.
Additional Info