Skip to content

Conversation

@xiaoxiaojx
Copy link
Member

Motivation / Use-Case

#534

Breaking Changes

no

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Jun 25, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #545 (8f109c6) into master (70ce174) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   88.77%   88.88%   +0.11%     
==========================================
  Files          11       11              
  Lines         686      693       +7     
  Branches      190      191       +1     
==========================================
+ Hits          609      616       +7     
  Misses         74       74              
  Partials        3        3              
Impacted Files Coverage Δ
src/CssModule.js 56.57% <100.00%> (+0.57%) ⬆️
src/index.js 91.76% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ce174...8f109c6. Read the comment docs.

jacob-ebey
jacob-ebey previously approved these changes Dec 22, 2020
@alexander-akait
Copy link
Member

You need tests for this

@xiaoxiaojx
Copy link
Member Author

You need tests for this

@alexander-akait :)

@alexander-akait
Copy link
Member

CI still broken

@xiaoxiaojx
Copy link
Member Author

CI still broken

npm ERR! errno 1
npm ERR! mini-css-extract-plugin@1.3.5 test:coverage: npm run test:only -- --collectCoverageFrom="src/**/*.js" --coverage "--ci"
npm ERR! Exit status 1
npm ERR!

It looks like the test:coverage command, and there is no problem running it locally, and there is no change in the snapshot update, so I am out of ideas :)

@alexander-akait
Copy link
Member

Do you read answer #534 (comment)?

@xiaoxiaojx
Copy link
Member Author

Well, non-essential, thanks for the reply

@alexander-akait
Copy link
Member

It works in some cases, yep, but in general not in all cases

@alexander-akait
Copy link
Member

Close due #534 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants