Skip to content

Conversation

@leeonfield
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Sep 10, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #585 into master will decrease coverage by 3.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   91.16%   87.47%   -3.69%     
==========================================
  Files           9        9              
  Lines         543      543              
  Branches      145      145              
==========================================
- Hits          495      475      -20     
- Misses         44       64      +20     
  Partials        4        4              
Impacted Files Coverage Δ
src/CssDependency.js 76.66% <ø> (-23.34%) ⬇️
src/CssModule.js 75.43% <ø> (-22.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1565706...4dd0d62. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need test to avoid regression, please create reproducible test repo if it is hard to create for you

@alexander-akait
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants