add types for ts support and support webpack v5 config #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 9 9
Lines 543 543
Branches 145 145
=======================================
Hits 495 495
Misses 44 44
Partials 4 4 Continue to review full report at Codecov.
|
alexander-akait
requested changes
Sep 28, 2020
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Sorry, we should use ts docs to generate types, also it was implemented after webpack@5 stable release
|
@alexander-akait are there any plans to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
add types for ts support and support webpack v5 config
Breaking Changes
Additional Info