feat(options): added query option that gets appended to the chunk href #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added query option that gets appended to the chunk href. This option can be a string or a synchronous function.
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
===========================================
- Coverage 88.75% 70.59% -18.17%
===========================================
Files 11 11
Lines 676 687 +11
Branches 184 190 +6
===========================================
- Hits 600 485 -115
- Misses 73 183 +110
- Partials 3 19 +16
Continue to review full report at Codecov.
|
alexander-akait
requested changes
Dec 22, 2020
Member
There was a problem hiding this comment.
it is out of scope this plugin, you have the filename option https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/src/plugin-options.json#L5 for this and chunkFIlename https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/src/plugin-options.json#L15
Author
|
🤦that totally covers the use-case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added query option that gets appended to the chunk href. This option can be a string or a
synchronous function.
This PR contains a:
Motivation / Use-Case
It is fairly common to append a query string to assets hosted on platforms like github-pages for cache invalidation. This change allows frameworks that pre-render HTML to append a query string while not loading duplicate chunks on the client.
Check the network log here for the problem: https://jacob-ebey.js.org/preact-webpack-prerender/
Breaking Changes
N/A
Additional Info