Skip to content

fix: check for error before using other arguments #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nielsslot wants to merge 1 commit into from
Closed

fix: check for error before using other arguments #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,14 +349,6 @@ export function pitch(request) {
}

childCompiler.runAsChild((error, entries, compilation) => {
const assets = Object.create(null);
const assetsInfo = new Map();

for (const asset of compilation.getAssets()) {
assets[asset.name] = asset.source;
assetsInfo.set(asset.name, asset.info);
}

if (error) {
return callback(error);
}
Expand All @@ -365,6 +357,14 @@ export function pitch(request) {
return callback(compilation.errors[0]);
}

const assets = Object.create(null);
const assetsInfo = new Map();

for (const asset of compilation.getAssets()) {
assets[asset.name] = asset.source;
assetsInfo.set(asset.name, asset.info);
}

compilation.fileDependencies.forEach((dep) => {
this.addDependency(dep);
}, this);
Expand Down