Skip to content

refactor: code #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 2 commits into from
Jul 5, 2021
Merged

refactor: code #784

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feed5e6
refactor: code
alexander-akait Jul 5, 2021
bd3fc9f
test: refactor
alexander-akait Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: code
  • Loading branch information
@alexander-akait
alexander-akait committed Jul 5, 2021
commit feed5e624a758cdb8caf18d1e97c5209f92aca69
34 changes: 17 additions & 17 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,35 +984,36 @@ class MiniCssExtractPlugin {
compiler.webpack.sources;
const source = new ConcatSource();
const externalsSource = new ConcatSource();
const includePathinfo = compilation.outputOptions.pathinfo;

for (const m of usedModules) {
let content = m.content.toString();
for (const module of usedModules) {
let content = module.content.toString();

if (includePathinfo) {
const readableIdentifier = module.readableIdentifier(requestShortener);

if (compilation.outputOptions.pathinfo) {
// From https://github.com/webpack/webpack/blob/29eff8a74ecc2f87517b627dee451c2af9ed3f3f/lib/ModuleInfoHeaderPlugin.js#L191-L194
const req = m.readableIdentifier(requestShortener);
const reqStr = req.replace(/\*\//g, "*_/");
const reqStr = readableIdentifier.replace(/\*\//g, "*_/");
const reqStrStar = "*".repeat(reqStr.length);
const headerStr = `/*!****${reqStrStar}****!*\\\n !*** ${reqStr} ***!\n \\****${reqStrStar}****/\n`;

content = headerStr + content;
}

if (/^@import url/.test(content)) {
// HACK for IE
// http://stackoverflow.com/a/14676665/1458162
if (m.media) {
if (module.media) {
// insert media into the @import
// this is rar
// TODO improve this and parse the CSS to support multiple medias
content = content.replace(/;|\s*$/, m.media);
content = content.replace(/;|\s*$/, module.media);
}

externalsSource.add(content);
externalsSource.add("\n");
} else {
if (m.media) {
source.add(`@media ${m.media} {\n`);
if (module.media) {
source.add(`@media ${module.media} {\n`);
}

const { path: filename } = compilation.getPathWithInfo(
Expand All @@ -1024,22 +1025,21 @@ class MiniCssExtractPlugin {

content = content.replace(new RegExp(AUTO_PUBLIC_PATH, "g"), undoPath);

if (m.sourceMap) {
if (module.sourceMap) {
source.add(
new SourceMapSource(
content,
m.readableIdentifier(requestShortener),
m.sourceMap.toString()
readableIdentifier,
module.sourceMap.toString()
)
);
} else {
source.add(
new RawSource(content, m.readableIdentifier(requestShortener))
);
source.add(new RawSource(content, readableIdentifier));
}

source.add("\n");

if (m.media) {
if (module.media) {
source.add("}\n");
}
}
Expand Down