Skip to content

Conversation

@njzydark
Copy link

@njzydark njzydark commented Aug 1, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Current isUrlRequest in hotModuleReplacement is not work in browser extension, because:

Chrome use chrome-extension://
Microsoft Edge use extension://
Firefox use moz-extension://

Breaking Changes

Additional Info

Chrome use chrome-extension://
Microsoft Edge use extension://
Firefox use moz-extension://
@alexander-akait
Copy link
Member

hmr should work in browser extensions, can you provide example when it will not work

@njzydark
Copy link
Author

njzydark commented Aug 3, 2021

hmr should work in browser extensions, can you provide example when it will not work

https://github.com/njzydark/chrome-extension-boilerplate/tree/css-hmr-not-work

npm i
npm run dev

When load extension from chrome and open options page, then change this file https://github.com/njzydark/chrome-extension-boilerplate/blob/css-hmr-not-work/src/options/app.module.less, the css hmr will not work


The main branch https://github.com/njzydark/chrome-extension-boilerplate is using my fixed version, css hmr work right

@alexander-akait
Copy link
Member

Yep, I see, I will fix test tomorrow and do release, thanks

@alexander-akait alexander-akait mentioned this pull request Aug 4, 2021
6 tasks
@njzydark njzydark deleted the fix-hmr branch August 5, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants