Adding description of using postcss-js parser with babel 6 compiler #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
suggested changes
Dec 21, 2016
Member
michael-ciniawsky
left a comment
There was a problem hiding this comment.
Thx again 👍 Just two grammar issues
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| > If you are using babel 6 compiler and up you need to do the following in order for setup to work |
Member
There was a problem hiding this comment.
babel 6 compiler=>Babel >= v6- in order for setup => in order for the/your setup to work
README.md
Outdated
|
|
||
| > If you are using babel 6 compiler and up you need to do the following in order for setup to work | ||
| > * It is suggested to have only **default** export per style module |
Member
There was a problem hiding this comment.
only => only one || only => one ?
README.md
Outdated
| > If you are using babel 6 compiler and up you need to do the following in order for setup to work | ||
| > * It is suggested to have only **default** export per style module | ||
| > * You need to add [babel-plugin-add-module-exports] to you configuration |
Member
There was a problem hiding this comment.
Maybe switch order here? But I'm nitpicking 🐤 😛
- add babel-plugin-add-module-exports
- only one default export per module/file
Contributor
Author
|
Done |
michael-ciniawsky
approved these changes
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postcss-js parser produce wrapped styles, adding description to fix this problem