Skip to content

Conversation

@hellatan
Copy link

@hellatan hellatan commented Apr 6, 2019

Notable Changes

Changes the usage documentation with respect to webpack loader order

Type

  • Docs

Issues

None

SemVer

  • Fix (:label: Patch)

Checklist

  • Lint and unit tests pass with my changes

@hellatan
Copy link
Author

hellatan commented Apr 8, 2019

why would tests fail with this just a markdown update?

Screen Shot 2019-04-08 at 4 32 44 PM

@alexander-akait
Copy link
Member

Need investigate, maybe need update dev deps

@alexander-akait
Copy link
Member

@hellatan can you rebase?

@jsf-clabot
Copy link

jsf-clabot commented Aug 14, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files           5        5           
  Lines         179      179           
  Branches       48       48           
=======================================
  Hits          174      174           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb5aaf...28a9496. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexander-akait alexander-akait merged commit 6b1da04 into webpack:master Aug 14, 2020
@hellatan hellatan deleted the patch-1 branch August 14, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants