Skip to content

Conversation

@jquense
Copy link

@jquense jquense commented May 15, 2020

Notable Changes

fixes a test that is incorrectly rewritten

Type

ℹ️ What type of changes does your code introduce?

  • CI
  • Fix
  • Perf
  • Docs
  • Test
  • Style
  • Build
  • Chore
  • Feature
  • Refactor

Checklist

ℹ️ You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works (if needed)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@jquense
Copy link
Author

jquense commented Aug 3, 2020

ping

@alexander-akait
Copy link
Member

hm CI failed 😞

@jquense
Copy link
Author

jquense commented Aug 3, 2020

yes it's just broken generally, for any PR. The problem is node 12 is producing slightly different snapshot results, than node 10 was and CI is configured to run on "latest". see: #425 (comment)

@alexander-akait
Copy link
Member

Oh, yes, we need to setup github actions, in my TODO on this week, I will ping you

@cap-Bernardito cap-Bernardito mentioned this pull request Aug 10, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants