Better sourcemaps support #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes source mapping when used with sass-loader. Also, we don't want to map to the postcss generated source, we want to map to the pre-postcss source.
Contributor
Author
|
Thanks for the merge. This change breaks the tests though, I'm wondering if it would be better to allow configuration of map options with loader params... |
Contributor
|
@badsyntax np, I fixing test right now. Also I will move loader to PostCSS 4.1. |
Contributor
Author
|
Great, thanks a lot 👍 |
Contributor
|
Released in 0.4.0 with all other PostCSS 0.4.1 features |
badsyntax
added a commit
to badsyntax/react-seed
that referenced
this pull request
Apr 21, 2015
Contributor
Author
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes source mapping when used with sass-loader.
Also, we don't want to map to the postcss generated source, we want to map to the pre-postcss source, so this is also an improvement for CSS source maps.
Inline source maps can be generated using
devtool: 'inline-source-map'.