Add postcss-loader-before-processing event #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks great. Could I ask you two changes:
|
33436d7 to
80edc87
Compare
Contributor
Author
|
Updated the pull request as requested. :) |
80edc87 to
f2ebb2d
Compare
f2ebb2d to
a570b18
Compare
Contributor
|
Looks good. Wait I second, I need to finish my talk and them I will release all changes in PostCSS projects. You don’t need this feature right now, correct? |
Contributor
Author
|
Cool :) which talk will you give? releasing in the near future would be great but doesn't need to be right now. |
Contributor
|
Released in 0.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature.
It allows third party webpack plugins to add or remove postcss plugins using the
postcss-loader-before-processingevent (using the webpack built in plugin system).An example can be seen here:
https://github.com/jantimon/postcss-loader/blob/33436d715119258053e5459b7cfde26eeecd0aa1/test/webpack-plugins/rewrite.js
Motivation:
There are cases where a postcss plugin is very tight cupeled with a webpack plugin as it has to access the webpack internals.
In this case it would be nice if this webpack could also add its postcss part to the loader.