Skip to content

Runaway promise #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ai merged 1 commit into from
Aug 31, 2016
Merged

Runaway promise #95

ai merged 1 commit into from
Aug 31, 2016

Conversation

@leyyinad
Copy link
Contributor

@leyyinad leyyinad commented Aug 31, 2016

In conjunction with bluebird, I get a couple of Warnings:

Warning: a promise was created in a handler at usr/app/node_modules/postcss-loader/index.js:100:13 but was not returned from it, see http://goo.gl/rRqMUw

Documentation states that one should at least return null to "signal that we didn't forget to return".

@ai ai merged commit b28fb23 into webpack:master Aug 31, 2016
@ai
Copy link
Contributor

ai commented Aug 31, 2016

Thanks!

@leyyinad leyyinad deleted the patch-1 branch August 31, 2016 10:05
@ai
Copy link
Contributor

ai commented Aug 31, 2016

Released in 0.11.1

@mcjfunk mcjfunk mentioned this pull request Jun 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leyyinad @ai