Merged
Conversation
…s too long Use case is the following: when the pinned content is too high for the window, add overflow:auto so that the user can scroll within that content as well.
Adds an optional fixedHeaderSelector to the option, allowing to trigger the pin as soon as that header is hit.
sorry, i was working directly via github.com, don't know how to cancel a commit here.. :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, these commits add classes to the three states(to eventually be used by css), adds an overflow:auto to pinned content that is higher than the window, and support for a fixed header.
Last thing to be corrected, still, is to correct the following behavior: when a pinned content is in overflow, and the end of the container is reached, the pinned content should change state as soon as its normal height hits the bottom, not its current height(the overflow:auto one)