Skip to content

Commit ecb19d6

Browse files
Rename Constants to Follow Kotlin Naming Conventions (commons-app#6107)
* Rename Constants to Follow Kotlin Naming Conventions >This PR refactors constant names in the project to adhere to Kotlin's UPPERCASE_SNAKE_CASE naming convention, improving code readability and maintaining consistency across the codebase. >Renamed the following constants in LoginActivity: >saveProgressDialog → SAVE_PROGRESS_DIALOG >saveErrorMessage → SAVE_ERROR_MESSAGE >saveUsername → SAVE_USERNAME >savePassword → SAVE_PASSWORD >Updated all references to these constants throughout the project. * Update Project_Default.xml
1 parent 940c074 commit ecb19d6

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.kt

+13-13
Original file line numberDiff line numberDiff line change
@@ -184,32 +184,32 @@ class LoginActivity : AccountAuthenticatorActivity() {
184184
// if progressDialog is visible during the configuration change then store state as true else false so that
185185
// we maintain visibility of progressDialog after configuration change
186186
if (progressDialog != null && progressDialog!!.isShowing) {
187-
outState.putBoolean(saveProgressDialog, true)
187+
outState.putBoolean(SAVE_PROGRESS_DIALOG, true)
188188
} else {
189-
outState.putBoolean(saveProgressDialog, false)
189+
outState.putBoolean(SAVE_PROGRESS_DIALOG, false)
190190
}
191191
outState.putString(
192-
saveErrorMessage,
192+
SAVE_ERROR_MESSAGE,
193193
binding!!.errorMessage.text.toString()
194194
) //Save the errorMessage
195195
outState.putString(
196-
saveUsername,
196+
SAVE_USERNAME,
197197
binding!!.loginUsername.text.toString()
198198
) // Save the username
199199
outState.putString(
200-
savePassword,
200+
SAVE_PASSWORD,
201201
binding!!.loginPassword.text.toString()
202202
) // Save the password
203203
}
204204

205205
override fun onRestoreInstanceState(savedInstanceState: Bundle) {
206206
super.onRestoreInstanceState(savedInstanceState)
207-
binding!!.loginUsername.setText(savedInstanceState.getString(saveUsername))
208-
binding!!.loginPassword.setText(savedInstanceState.getString(savePassword))
209-
if (savedInstanceState.getBoolean(saveProgressDialog)) {
207+
binding!!.loginUsername.setText(savedInstanceState.getString(SAVE_USERNAME))
208+
binding!!.loginPassword.setText(savedInstanceState.getString(SAVE_PASSWORD))
209+
if (savedInstanceState.getBoolean(SAVE_PROGRESS_DIALOG)) {
210210
performLogin()
211211
}
212-
val errorMessage = savedInstanceState.getString(saveErrorMessage)
212+
val errorMessage = savedInstanceState.getString(SAVE_ERROR_MESSAGE)
213213
if (sessionManager.isUserLoggedIn) {
214214
showMessage(R.string.login_success, R.color.primaryDarkColor)
215215
} else {
@@ -396,9 +396,9 @@ class LoginActivity : AccountAuthenticatorActivity() {
396396
fun startYourself(context: Context) =
397397
context.startActivity(Intent(context, LoginActivity::class.java))
398398

399-
const val saveProgressDialog: String = "ProgressDialog_state"
400-
const val saveErrorMessage: String = "errorMessage"
401-
const val saveUsername: String = "username"
402-
const val savePassword: String = "password"
399+
const val SAVE_PROGRESS_DIALOG: String = "ProgressDialog_state"
400+
const val SAVE_ERROR_MESSAGE: String = "errorMessage"
401+
const val SAVE_USERNAME: String = "username"
402+
const val SAVE_PASSWORD: String = "password"
403403
}
404404
}

0 commit comments

Comments
 (0)