build: Update phpunit/phpunit to 10.5.58

- Update PHPUnit config for version 10 with `--migrate-configuration`
- Enabled options to display all notices, deprecations, etc.
- Suppress the deprecation notice for getMockForAbstractClass (T407015)
- Add missing @Covers

Change-Id: I9a7610a524166c2d5f417ac5dcc66522341f37fc

Author: umherirrender

composer.json

@@ -32,7 +32,7 @@
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
 		"php-parallel-lint/php-parallel-lint": "1.4.0",
-		"phpunit/phpunit": "9.6.21",
+		"phpunit/phpunit": "10.5.58",
 		"wikimedia/testing-access-wrapper": "~2.0.0 || ~3.0.0",
 		"wikimedia/update-history": "^1.0.1"
 	},

phpunit.xml.dist

@@ -1,10 +1,21 @@
 <?xml version="1.0"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" beStrictAboutTestsThatDoNotTestAnything="true" beStrictAboutOutputDuringTests="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
-  <coverage includeUncoveredFiles="true">
+<phpunit
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	colors="true"
+	displayDetailsOnTestsThatTriggerDeprecations="true"
+	displayDetailsOnTestsThatTriggerErrors="true"
+	displayDetailsOnTestsThatTriggerNotices="true"
+	displayDetailsOnTestsThatTriggerWarnings="true"
+	displayDetailsOnPhpunitDeprecations="true"
+	requireCoverageMetadata="true"
+	beStrictAboutTestsThatDoNotTestAnything="true"
+	beStrictAboutOutputDuringTests="true"
+	xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd">
+  <source>
     <include>
       <directory suffix=".php">./src</directory>
     </include>
-  </coverage>
+  </source>
   <php>
     <!-- The default of 100 is too low -->
     <ini name="xdebug.max_nesting_level" value="1000"/>

tests/Grammar/AlternativeTest.php

@@ -34,6 +34,7 @@ public function testException() {
 	public function testGenerateMatches( $rets, $expect ) {
 		$matchers = [];
 		foreach ( $rets as $ret ) {
+			// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 			$matcher = $this->getMockBuilder( Matcher::class )
 				->onlyMethods( [ 'generateMatches' ] )
 				->getMockForAbstractClass();

tests/Grammar/CheckedMatcherTest.php

@@ -15,6 +15,7 @@
 class CheckedMatcherTest extends MatcherTestBase {
 
 	public function testGenerateMatches() {
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$matcher = $this->getMockBuilder( Matcher::class )
 			->onlyMethods( [ 'generateMatches' ] )
 			->getMockForAbstractClass();

tests/Grammar/MatcherTest.php

@@ -44,6 +44,7 @@ public function testCreate() {
 	}
 
 	public function testDefaultOptions() {
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$matcher = $this->getMockForAbstractClass( Matcher::class );
 		'@phan-var Matcher $matcher';
 
@@ -74,6 +75,7 @@ public function testDefaultOptions() {
 
 	public function testNext() {
 		$matcher = TestingAccessWrapper::newFromObject(
+			// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 			$this->getMockForAbstractClass( Matcher::class )
 		);
 
@@ -115,6 +117,7 @@ public function testNext() {
 	 * @param bool $expect
 	 */
 	public function testMatch( $list, $options, $ret, $expectStart, $expect ) {
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$matcher = $this->getMockBuilder( Matcher::class )
 			->onlyMethods( [ 'generateMatches' ] )
 			->getMockForAbstractClass();
@@ -196,6 +199,7 @@ public function testMatchSignificantWhitespace() {
 			$Iws, $tok, $ws, $Iws, $tok, $ws, $expectBlock, $ws
 		] );
 
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$matcher = $this->getMockForAbstractClass( Matcher::class );
 		$matcher->method( 'generateMatches' )->willReturn( new ArrayIterator( [
 			new GrammarMatch( $testList, 1, 6, null, [
@@ -224,6 +228,7 @@ public function testMatchSignificantWhitespace() {
 	public function testMakeMatch() {
 		$dummy = new ComponentValueList();
 		$matcher = TestingAccessWrapper::newFromObject(
+			// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 			$this->getMockForAbstractClass( Matcher::class )
 		);
 		$matcher2 = TestingAccessWrapper::newFromObject( $matcher->capture( 'foo' ) );

tests/Grammar/NonEmptyTest.php

@@ -22,6 +22,7 @@ class NonEmptyTest extends MatcherTestBase {
 	 * @param array $expect
 	 */
 	public function testGenerateMatches( $start, $ret, $expect ) {
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$matcher = $this->getMockBuilder( Matcher::class )
 			->onlyMethods( [ 'generateMatches' ] )
 			->getMockForAbstractClass();

tests/Grammar/QuantifierTest.php

@@ -167,6 +167,7 @@ public static function provideGenerateMatches() {
 
 	public function testEmptyMatch() {
 		$list = new ComponentValueList();
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$matcher = $this->getMockBuilder( Matcher::class )
 			->onlyMethods( [ 'generateMatches' ] )
 			->getMockForAbstractClass();

tests/Parser/DataSourceTokenizerTest.php

@@ -34,6 +34,7 @@ public function testCharacterNormalization() {
 		$this->assertSame( '-', $t->nextChar() );
 		$this->assertSame( DataSource::EOF, $t->nextChar() );
 
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$mock = $this->getMockForAbstractClass( DataSource::class );
 		$mock->method( 'readCharacter' )->willReturnOnConsecutiveCalls(
 			"\u{D7FF}", "\u{D800}", "\u{DFFF}", "\u{E000}", DataSource::EOF

tests/Sanitizer/CounterStyleRuleSanitizerTest.php

@@ -5,6 +5,10 @@
 use Wikimedia\CSS\Sanitizer\RuleSanitizerTestBase;
 
 // phpcs:disable Generic.Files.LineLength
+
+/**
+ * @covers \Wikimedia\CSS\Sanitizer\CounterStyleAtRuleSanitizer
+ */
 class CounterStyleRuleSanitizerTest extends RuleSanitizerTestBase {
 
 	protected function getSanitizer( $options = [] ) {

tests/Sanitizer/RuleSanitizerTest.php

@@ -23,6 +23,7 @@ class RuleSanitizerTest extends RuleSanitizerTestBase {
 	protected function getSanitizer( $options = [] ) {
 		$mb = $this->getMockBuilder( RuleSanitizer::class )
 			->onlyMethods( [ 'doSanitize', 'handlesRule' ] );
+		// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 		$san = $mb->getMockForAbstractClass();
 		$san->method( 'handlesRule' )->willReturn( true );
 
@@ -34,6 +35,7 @@ protected function getSanitizer( $options = [] ) {
 
 			case 'rules':
 				$method = 'sanitizeRuleBlock';
+				// @phan-suppress-next-line PhanDeprecatedFunction Soft-deprecated in phpunit 10
 				$arg = [ $mb->getMockForAbstractClass() ];
 				$arg[0]->method( 'handlesRule' )->willReturnCallback( static function ( $rule ) {
 					return $rule instanceof AtRule && !strcasecmp( $rule->getName(), 'foo' );