Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Type problem in 0.7.4 with Typescript 2.4.1 + react 15.6.1 #3

Open
@estaub

Description

@estaub

Typescript 2.4.1 reports when compiling csstransitiongroup.d.ts:

Error:(13, 5) TS2424:Class 'Component<CSSTransitionGroupProps, {}>' defines instance member function 'componentDidMount', but extended class 'CSSTransitionGroup' defines it as instance member property.

This is regarding:

export declare class CSSTransitionGroup extends Component<CSSTransitionGroupProps, {}> {
    static defaultProps: any;
    private mounted;
    componentDidMount: () => boolean;
    render(): JSX.Element;
}

which conflicts with the ComponentLifeCycle member:

componentDidMount?(): void;
I'm surprised that Typescript would care whether it's a member function or member property. Note also that the React def claims componentDidMount() is optional and returns void, whereas react-css-transition claims it is required and returns boolean.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions