fix: uppercase classes should be valid#281
Open
lianghx-319 wants to merge 1 commit intowindicss:mainfrom
Open
Conversation
Member
|
I do not get what you are trying to achieve. Yes uppercase can be valid class names, but in Windi CSS all utils are lowercase and I didn't see how this helps |
Author
|
For custom plugin, always lowercase limits how people implement there business usage. For me, I create a plugin generate |
Author
|
Another reason: windicss core doesn't ignore uppercase classNames, such lowercase limitations make different behavior between windicss ordinary usage and webpack-plugin uasge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Why
Such class names will be filtered, but they are valid too.