fix(vite-plugin-windicss): fix vite5 hmr#326
Merged
antfu merged 4 commits intowindicss:mainfrom Dec 25, 2023
markthree:main
Merged
fix(vite-plugin-windicss): fix vite5 hmr#326antfu merged 4 commits intowindicss:mainfrom markthree:main
antfu merged 4 commits intowindicss:mainfrom
markthree:main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In vite5,
watchChangeis triggered beforehmreven if thedevServeris started, which causes the hot update to fail, add theinHmrflag to skip the repeat trigger (as in vite4)I simply tested vite4 and vite5 in the local area, and now their HMR works well.
If there is any case, I was ignored, please tell me. 🤣
Maybe there are stricter restrictions here, even specific to the vite version