Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aterrien/jQuery-Knob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: winwaed/jQuery-Knob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 30, 2014

  1. Numeric validation for the colored foreground arc 

    It is possible for the data value to include non-numeric characters. This happens explicitly with modifications such as: http://stackoverflow.com/questions/18955708/how-to-display-units-with-jquery-knob

This modification works well for the label, but the addition of the '%' character causes the arc not to be displayed when the page is refreshed. The above fixes this and removes all non-number characters from the value before attempting to plot it.
    @winwaed
    winwaed committed Jan 30, 2014
    Configuration menu
    Copy the full SHA
    54e8993 View commit details
    Browse the repository at this point in the history
Loading