Skip to content

update to ecmel/vscode-html-css version 2 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shadowwa
Copy link

Hi,

I wanted to add the glob functionnality to be able to use something like "html-css-support.styleSheets": ["src/**/*.css"] but finally ended up updating the whole code to match the current ecmel/vscode-html-css one.

I've also modified the detail/document of the completion items to show from which file the selector come from and the css rules applied to this selector.

I'm not used to coc.nvim api and not sure I've choose the best solution when modifying the code, for example, int src/extension.ts, I had to replace

window.activeTextEditor

by

workspace.getDocument(event.bufnr).textDocument

maybe there is a simpler replacement.

The one thing I wasn't able to adapt was the range in Provider.getCompletionItems()

@yaegassy
Copy link
Owner

yaegassy commented Jan 6, 2025

@shadowwa Hi, sorry for the delayed response.

Thank you for the amazing Pull Request.

It seems that the changes for v2 will significantly alter the code structure, so it might be better to create a new coc extension instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants