Skip to content

Using the plugin hangs vscode forever or ask for a restart #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dragod opened this issue Apr 21, 2016 · 25 comments
Closed

Using the plugin hangs vscode forever or ask for a restart #12

Dragod opened this issue Apr 21, 2016 · 25 comments
Labels

Comments

@Dragod
Copy link

Dragod commented Apr 21, 2016

While opening a big project and switch to a huge html page, I got a message on top that say fetching css etc. After that vscode become unresponsive and crash in a while. Unistalling the plugin solved my problem.

@zignd
Copy link
Owner

zignd commented Apr 21, 2016

I will take a look into that

@AlexStacker
Copy link

I think the solution is to search the CSS file or search for the current link SRC HTML and style tags by configuring the directory specified in the file.

--- By Machine Translation

@zignd
Copy link
Owner

zignd commented Apr 22, 2016

@iwx I don't think so because the VS Code API allows me to perform a search for the file types I want, but maybe the issue is related to some sort of thread blocking, if so I can easily fix that with JavaScript promises.

@zignd zignd added the bug label May 23, 2016
@zignd
Copy link
Owner

zignd commented Sep 10, 2016

Would you guys mind testing it again? I completely rewrote the extension and the newest release is already on the Marketplace.

@AurelioDeRosa
Copy link

I've tried it today and it still blocks VS code. I'm on a Windows 10 machine.

@zignd
Copy link
Owner

zignd commented Sep 13, 2016

Thanks for letting me know, @AurelioDeRosa. Do you think you can help me reproduce the issue? I'd like to fix this issue but I'm not being able to reproduce it myself, I tried multiple times with large CSS files, minified and not minified ones, but no success. If you could provide me a Visual Studio Code workspace, maybe in a public repository here on GitHub if you prefer... I mean, I only need to be able to reproduce it to fix it.

@AurelioDeRosa
Copy link

Give me an hour and I'll get back to you with a public repo where I have the issue.

@zignd
Copy link
Owner

zignd commented Sep 13, 2016

Great!

@AurelioDeRosa
Copy link

The keystone demo repository doesn't work with the plugin. Hopefully this helps.

@zignd
Copy link
Owner

zignd commented Sep 13, 2016

I will try it out as soon as I get home from work. Thanks @AurelioDeRosa!

@AurelioDeRosa
Copy link

Any news about this issue? Where you able to reproduce the problem with the repository I suggested?

@zignd
Copy link
Owner

zignd commented Sep 16, 2016

I managed to reproduce the error, thank you, and I will work on a fix tonight or on this weekend. Sorry for not fixing it earlier I ended up with lots of things to finish at work and had no time to work on the extension.

@AurelioDeRosa
Copy link

No worries. I work on several open source projects and I know how it works. I just wanted to check if you were able to reproduce the issue.

@zignd
Copy link
Owner

zignd commented Sep 18, 2016

Hi there guys, sorry asking for it again, but would you mind testing it on more time, please? I released a new version to fix a problem I managed to identify related to parsing documents in parallel and asynchronously. Thanks to @AurelioDeRosa for showing me the steps to reproduce the issue.

Here's the commit with the changes: 3ff81e3

@AurelioDeRosa
Copy link

I've tried the new version. The first time the plugin caches the classes, it works fine. As soon as you click the button to recache, it hangs again.

@flyher
Copy link

flyher commented Sep 18, 2016

@zignd
hi ,the new version has the same bug.
microsoft/vscode#12211

@AurelioDeRosa
i have the same question

@zignd
Copy link
Owner

zignd commented Sep 18, 2016

Thanks @AurelioDeRosa, it's hanging for me too, I will look into that right now.


@flyher that's very weird, but I don't think it's related to the extension, I uninstalled it checked the task manager again and it showed me again the same processes.

@zignd
Copy link
Owner

zignd commented Sep 18, 2016

I think I will need some help to solve this issue, I have no idea why it's hanging like that, I've done this kind of asynchronous parallel processing multiple times in Node.js with plain JavaScript using the same async library I'm using and it always worked nicely... But for some reason I can't get it to work on the extension. It feels like it's reaching some sort of limit and it compromises the Visual Studio Code performance. And I've noticed that in some rare occasions it manages to perform the task without hanging the editor.

The issue seems to be happening on this section of the code, the moment it runs multiple tasks in parallel for each of the CSS files the extension found on the workspace: https://github.com/Zignd/HTML-CSS-Class-Completion/blob/3ff81e3b99244be42620e3990d4eb0f097bea3d6/src/extension.ts#L30-L57

Do you think you can help me with that, @AurelioDeRosa? Maybe I should ask for assistance on the VS Code repository.

@AurelioDeRosa
Copy link

Hey. Sorry, but at the moment I'm bit short in spare time. I'd suggest to ask for help considering the amount of issues people are opening that are related to this plugin.

@zignd
Copy link
Owner

zignd commented Sep 27, 2016

I'll try to get in touch with someone from the VS Code team, maybe someone
there is willing to help me. Thanks Aurelio.

2016-09-27 7:16 GMT-03:00 Aurelio De Rosa notifications@github.com:

Hey. Sorry, but at the moment I'm bit short in spare time. I'd suggest to
ask for help considering the amount of issues people are opening that are
related to this plugin.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADC_tsEURdUuzE-VjylYvW5crHgYkXkiks5quOzvgaJpZM4IMvIB
.

Igor H. Vieira - Zignd

@yihuihan
Copy link

I run into this problem either on the vscode of version 1.6.1, any updates on this now?

@MopideviAshok
Copy link

I also run into the same problem, how to fix it?

@TheColorRed
Copy link

TheColorRed commented Nov 1, 2016

I believe I have found the source of the issue:

https://github.com/Zignd/HTML-CSS-Class-Completion/blob/master/src/parse-engine-gateway.ts#L10

Running that on every file that is found is hard on the client.

See PR #34

@westy92
Copy link

westy92 commented Oct 6, 2017

vscode was continually freezing on startup for me. Uninstalling this extension fixed it.
code --uninstall-extension Zignd.html-css-class-completion

vscode: 1.17.0
os: ubuntu 16.04 x64

@zignd
Copy link
Owner

zignd commented Oct 14, 2017

I guess this issue has been fixed in the latest update. Thanks to Erich Gamma for this great pull request #90.

@zignd zignd closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants