Skip to content

support for "class" attribute in jsx #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2018
Merged

support for "class" attribute in jsx #110

merged 1 commit into from
Feb 18, 2018

Conversation

marc3lsk
Copy link

@marc3lsk marc3lsk commented Jan 16, 2018

A lot of jsx-compatible frameworks support traditional "class" attribute. I find the code much nicer when class is used instead of className.

@zignd zignd merged commit c99f755 into zignd:master Feb 18, 2018
@patricklafrance
Copy link

patricklafrance commented Sep 25, 2018

It would be quite nice if the attributes would be configurable.

For example if you use the babel-react-css-module plugin, you end up applying your "local" css class to the styleName attribute

<div styleName="modal" className="ba b--light-gray"> {children} </div>

Another example if when applying a css class for the active state of the NavLink component:

<NavLink to={url} className="link" activeClassName="menu-link--active"> {text} </NavLink>

Thank you,

Patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants