This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Closed
Conversation
Owner
|
@Poincare Sweet thanks for spending the time to submit the PR. I'll take a look |
Owner
There was a problem hiding this comment.
I generally shy away from making instance variables within a method unless it makes sense for the object itself.
Owner
|
I do appreciate the PR, but I'm going to close this unmerged. I left some comments in the code if you want to give me a hand and submit another one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit begins the process of separating out and cleaning up the redundancy code. All unit tests pass after commit.
Obviously, this isn't a large commit, but, I'll keep following up on it with bits and pieces and whip the class into shape!
Let's get this Code Climate GPA up!