Fix 0 and 0px to match and resolve as a redundancy

[mduvall]

Fixes #32

[zmoazeni]

Nice! Thanks!

[zmoazeni]

I think this logic is the only thing I don't love about this implementation. This logic could be pushed into the instance methods of the class. Perhaps only in the equality check.

[zmoazeni]

@mduvall Let me know if you want to finish this out with my comment above. Otherwise I can take it. I like the rest of the code and especially appreciate the tests.

Could you also update the CHANGELOG and the CONTRIBUTORS?

You can add a new ## (Unreleased) ## block in the Changelog.

[mduvall]

@zmoazeni I'll definitely finish this out tonight, thanks for the feedback! 👍

[mduvall]

@zmoazeni I updated the code to make the function an instance method, this had the nice convenience of only doing the normalization for the parser equality in hash.

[zmoazeni]

This bit is redundant. Because of from_parser

[mduvall]

Oops, yeah - removed it since the strip is done there

[zmoazeni]

Some edgecasey tests here would go a long way too.

Thanks for all the work on this!

[zmoazeni]

Typo? :)

I should have said, you don't have to put your info in here if you rather not. I just like to have some credit where credit is due.

[mduvall]

Oops x 2, put my Twitter handle here, fixed

[zmoazeni]

Ah. I don't care either way. It's attributing you, so do what you want :)

Sent from my iPhone

On Apr 12, 2013, at 7:52 PM, Matt DuVall notifications@github.com wrote:

In CONTRIBUTORS.md:

@@ -1,3 +1,4 @@

• Zach Moazeni zach.moazeni@gmail.com @zmoazeni
• Carson McDonald @carsonmcdonald
• Martin Kuckert @MKuckert
  +* Matt DuVall @mduvall_
  Oops x 2, put my Twitter handle here, fixed

—
Reply to this email directly or view it on GitHub.

[mduvall]

@zmoazeni I added some base case tests in types_test.rb - let me know if there is anything else!

[zmoazeni]

I don't think we should add % here. I was thinking of moving this check in the normalize method.

[zmoazeni]

@mduvall This is really close. I'm going to pull this down and make some tweaks then merge it in.

Thanks for all the hard work!

[zmoazeni]

@mduvall I'm going to go ahead and close this. I cherry-picked the majority of this code and tweaked a bit in d5ba00f

Thanks again for the help!