This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Closed
Conversation
Owner
|
@mekka Thanks! I really appreciate you taking the time to put together the PR. There are a few things that I want to tweak, and I want to squash this all into one commit. So I'll probably close this PR unmerged and bring in the relevant bits. I'll give you a heads up once it is in master though. |
zmoazeni
added a commit
that referenced
this pull request
Apr 14, 2013
This support behaves very similar to the SASS support. It will attempt to compile the css prior to checking for redundancies. For c-versions of ruby, therubyracer is required. For jruby, therubyrhino. More information can be found at http://lesscss.org/ refs: #52, #10
Owner
|
Closing unmerged. Thanks again. |
Author
|
Cool beans. I looked at the changes you made and they all make sense. Good point on squashing. |
|
My English is poor, this passage is Bing translation, so there are many problems in the configuration. Does not use this site, are my reasons.Thank you, I will try to study English. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests pass, and I added a few more tests for the CLI to verify that we can correctly parse LESS and SASS files as well as CSS. The SASS test stylesheet specifically covers the shorthand format. I also did some minor refactoring on cli.rb to make it easier to test, and bring down the complexity of the execute method.
LESS is an optional dependency, so users don't need to install the LESS gem if they're not going to use it. LESS tests are skipped if the LESS gem is not installed.
I merged all the latest changes from master before this pull request, so all the refactored stuff and bug fixes are already in.
cheers