Precompilation issues

[christoffer]

CSS Splitter works like a charm for me in development, but I can't get it to work at all in production with asset pre-compilation.

When running rake assets:precompile I end up with a file named application-web_split2.css-<fingerprint>.split2 Instead of the expected application-web_split2.css that I get when running in development.

It would seem that the .split2 is not run through the css_splitter template handler, because it contains the full content of the original css file. I guess that would also explain why the file ending is still .split2 in the asset folder.

# precompilation settings in production.rb
assets_configuration.precompile += %w{ <other files> application-web.css application-web_split2.css }

# app/assets/stylesheets/application-web_split2.css.split2
//= include 'application-web.css'

# app/assets/stylesheets/application-web.css.scss
# <way, way to much stuff>

Let me know if I can help out with more information.

[yaronyosef]

same here

[jhilden]

Thank you for the bug report @christoffer & @yaronyosef

I played around a little bit with the test dummy app that's part of the css_splitter codebase (see my last 2 commits 1ccf549 0883935) to test if the rake assets:precompile task is working correctly and it seems to be working fine for me:

# test/dummy/config/production.rb
config.assets.precompile += %w( too_big_stylesheet.css too_big_stylesheet_split2.css )

Resulting files in test/dummy/public/assets after running rake assets:precompile:

too_big_stylesheet-5cc98b091feb0f5796204ba28a6e3985.css
too_big_stylesheet-5cc98b091feb0f5796204ba28a6e3985.css.gz
too_big_stylesheet.css
too_big_stylesheet.css.gz
too_big_stylesheet_split2-b4a3fe48d390374e767d5071901ddb29.css
too_big_stylesheet_split2-b4a3fe48d390374e767d5071901ddb29.css.gz
too_big_stylesheet_split2.css
too_big_stylesheet_split2.css.gz

Seems correct, or?

The test dummy app is currently using rails version 3.2.8 and sprockets version 2.1.3. What version are you running? Maybe something in sprockets has changed?

In any case, what we should aim for is a test case to reproduce the bug that you are describing. Could you help out with that?

[jhilden]

@christoffer @yaronyosef Do you have any version information (-> sprockets) for me or any other pointers on why it doesn't compile correctly for you?

[christoffer]

@jhilden Hey Jakob, sorry for my non-reactive state (holidays relaxness still wearing off :/).

I have a ticket here in my tracker for checking this out this week actually, as we really want to include this on our production system.

Right off the bat I'm suspecting that it might be an issue with our age-old rails version: 3.1.1 with Sprockets 2.0.4 – but I'll have to wait until I can carve out some time to get a a failing test in place.

Thanks for pinging me.

[jhilden]

@christoffer can you check if the merged pull request #3 by @aaronjensen fixes the problems?

[christoffer]

Pull request #3 does solve a part of it; Sprockets now picks up the split2 correct and runs it.

However, when running this now I get another error, but this time from from sass:

Invalid CSS after " src": expected comma, was ": url("

Looking into the issue now, but I think it's unrelated to the issue of this PR, so I'd suggest closing as fixed.

I'll report more about the sass integration issue when I know more, it might be only related to the old sprockets version we have (2.0.1).

Thanks!

[jhilden]

@christoffer Can I close this issue?

[christoffer]

Yes, please. Turns out I had multiple issues, where the first one was resolved by merging #3, and the second one resolved by #5.

Thanks,
/Christoffer