Follow sproket engine interface guidelines#70
Merged
jhilden merged 2 commits intozweilove:masterfrom Aug 22, 2016
Merged
Conversation
Contributor
lib/css_splitter/sprockets_engine.rb
Outdated
| data = input[:data] | ||
| context = input[:environment].context_class.new(input) | ||
|
|
||
| data = self.new(filename) { data }.render(context, {}) |
Contributor
There was a problem hiding this comment.
i find this syntax a little hard to understand. could this be expressed in a more simple way?
Contributor
Author
Contributor
|
@jhilden looks good. Fixes deprecations. |
|
Any plans to finally merge this and release a new gem version? It would be pretty helpful. |
Contributor
|
Sorry for the delay, since I'm on vacation. PR is merged an release should follow in the next couple of days. Thanks for testing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#supporting-all-versions-of-sprockets-in-processors
new.renderon Sprokets engines is deprecated as of Sprokets v3.7.0 (its currently called through theSprockets::LegacyTiltProcessorclass - seesprockets-3.7.0/lib/sprockets/legacy_tilt_processor.rb:20).This PR implement the class method
callwhich instantiates aCssSplitter::SproketEngineand callsrender.