Skip to content

example for feature #89 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jogibear9988
Copy link
Contributor

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

example for feature of minification of css #89

@jogibear9988 jogibear9988 marked this pull request as draft November 9, 2021 22:29
@@ -10,1341 +10,1341 @@ public static class PropertyNames
/// <summary>
/// The align-content declaration.
/// </summary>
public static readonly String AlignContent = "align-content";
public const String AlignContent = "align-content";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are public. Can you keep them static readonly?

@jogibear9988
Copy link
Contributor Author

I changed them to "const" so I could use them in a switch. But this could be reverted. Maybe it also works with new patern matching switch without that change.

What do you think about the overall concept? Is this a way to do Simplification/Minification of CSS as part of AngleSharp.Css ?

@FlorianRappl
Copy link
Contributor

What do you think about the overall concept? Is this a way to do Simplification/Minification of CSS as part of AngleSharp.Css ?

Yeah we can leave it like that - personally I think for consistency having a dedicated formatter would make sense, too, but this also works.

I changed them to "const" so I could use them in a switch. But this could be reverted. Maybe it also works with new patern matching switch without that change.

Understood - yes, I think it does work in the pattern matching style using references.

@FlorianRappl
Copy link
Contributor

Will be part of 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants