Consider selectors containg #id or .class qualified #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me. I'd like some more input by others before merging. |
Member
There was a problem hiding this comment.
To match the bit below, I'd change this to:
Using an attribute selector qualified by an ID should not result in a warning
I'd also move it to be nearer to line 38 test since they go together.
Member
|
I added some feedback re: clarity in the tests, but otherwise it looks good to me. |
Contributor
Author
|
All right, thank you for checking this out! 8-) |
frvge
added a commit
that referenced
this pull request
Jan 26, 2016
Selectors containing #id or .class are considered to be qualified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #505.
@frvge Please take a quick look.