Skip to content

Consider selectors containg #id or .class qualified #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frvge merged 2 commits into from
Jan 26, 2016
Merged

Consider selectors containg #id or .class qualified #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ad0b73
Consider selectors containg #id or .class qualified
gurdiga Jan 14, 2016
a5631b0
Consider selectors containg #id or .class qualified (review tweaks)
gurdiga Jan 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/rules/unqualified-attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ CSSLint.addRule({
//initialization
init: function(parser, reporter) {
"use strict";

var rule = this;

parser.addListener("startrule", function(event) {

var selectors = event.selectors,
selectorContainsClassOrId = false,
selector,
part,
modifier,
Expand All @@ -30,8 +32,19 @@ CSSLint.addRule({
if (part.type === parser.SELECTOR_PART_TYPE) {
for (k=0; k < part.modifiers.length; k++) {
modifier = part.modifiers[k];
if (modifier.type === "attribute" && (!part.elementName || part.elementName === "*")) {
reporter.report(rule.desc, part.line, part.col, rule);

if (modifier.type === "class" || modifier.type === "id") {
selectorContainsClassOrId = true;
break;
}
}

if (!selectorContainsClassOrId) {
for (k=0; k < part.modifiers.length; k++) {
modifier = part.modifiers[k];
if (modifier.type === "attribute" && (!part.elementName || part.elementName === "*")) {
reporter.report(rule.desc, part.line, part.col, rule);
}
}
}
}
Expand Down
11 changes: 10 additions & 1 deletion tests/rules/unqualified-attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,17 @@
"Using a qualified attribute selector should not result in a warning": function() {
var result = CSSLint.verify("input[type=text] { font-size: 10px; } ", {"unqualified-attributes": 1 });
Assert.areEqual(0, result.messages.length);
}
},

"Using an attribute selector qualified by a class should not result in a warning": function(){
var result = CSSLint.verify(".fancy[type=text] { font-size: 10px; }", {"unqualified-attributes": 1 });
Assert.areEqual(0, result.messages.length);
},

"Using an attribute selector qualified by an ID should not result in a warning": function(){
var result = CSSLint.verify("#fancy[type=text] { font-size: 10px; }", {"unqualified-attributes": 1 });
Assert.areEqual(0, result.messages.length);
}

}));

Expand Down