Font-Family names and the Font-compound property #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm working on rebasing and updating this patch. There are some "interesting" cases w/r/t escaped identifiers to address. |
cscott
pushed a commit
to cscott/parser-lib
that referenced
this pull request
Feb 5, 2016
This uses the Matcher framework to handle a fairly-complex shorthand property. This patch is based on a patch set by Onno van der Zee, originally submitted as PR CSSLint#164. Using the Matcher framework allowed the original implementation to be greatly simplified, but many of the test cases are from the original patch set.
cscott
pushed a commit
to cscott/parser-lib
that referenced
this pull request
Feb 5, 2016
This uses the Matcher framework to handle a fairly-complex shorthand property. This patch is based on a patch set by Onno van der Zee, originally submitted as PR CSSLint#164. Using the Matcher framework allowed the original implementation to be greatly simplified, but many of the test cases are from the original patch set.
cscott
pushed a commit
to cscott/parser-lib
that referenced
this pull request
Feb 5, 2016
This uses the Matcher framework to handle a fairly-complex shorthand property. This patch is based on a patch set by Onno van der Zee, originally submitted as PR CSSLint#164. Using the Matcher framework allowed the original implementation to be greatly simplified, but many of the test cases are from the original patch set.
cscott
added a commit
to cscott/parser-lib
that referenced
this pull request
Feb 5, 2016
This uses the Matcher framework to handle a fairly-complex shorthand property. This patch is based on a patch set by Onno van der Zee, originally submitted as PR CSSLint#164. Using the Matcher framework allowed the original implementation to be greatly simplified, but many of the test cases are from the original patch set.
Contributor
|
This patch set has been rebased as PR #201. Closing this issue in favor of that one. |
cscott
added a commit
to cscott/parser-lib
that referenced
this pull request
Feb 6, 2016
This uses the Matcher framework to handle a fairly-complex shorthand property. This patch is based on a patch set by Onno van der Zee, originally submitted as PR CSSLint#164. Using the Matcher framework allowed the original implementation to be greatly simplified, but many of the test cases are from the original patch set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.