Validate font-family and the font compound property.
#201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@cscott: this needs a rebase; after that feel free to merge it. |
More carefully validate the <ident> type, since the CSS spec gives various restrictions on the identifiers allowed.
This uses the Matcher framework to handle a fairly-complex shorthand property. This patch is based on a patch set by Onno van der Zee, originally submitted as PR CSSLint#164. Using the Matcher framework allowed the original implementation to be greatly simplified, but many of the test cases are from the original patch set.
cscott
added a commit
that referenced
this pull request
Feb 6, 2016
Validate `font-family` and the `font` compound property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
Matcherframework (PR #199) to handle a fairly-complex shorthand property.This patch is based on a patch set by Onno van der Zee, originally submitted as PR #164. Using the
Matcherframework allowed the original implementation to be greatly simplified, but many of the test cases are from the original patch set.Note that this PR is rebased on PR #179, which itself includes PR #180. It also includes PR #197, #198, and #199. These other pull requests should be merged first; this PR can then be rebased on master.