Properly parse CSS strings/URLs/identifiers with escape sequences. #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
|
@XhmikosR this one's pretty important, too, since it eliminates an |
Contributor
Author
|
Pinging @frvge on this patch. |
81c284b to
0eac1e6
Compare
Contributor
Author
|
Found some issues with tokenization of strings containing escaped newlines; rebased & fixed them (and added better test cases). |
The CSS escape syntax is not the same as JavaScript escapes -- and besides, using `eval` is evil. Write a proper parser (and serializer) for CSS strings with escape sequences. Regular expressions in this patch based on those found in https://www.w3.org/TR/CSS21/grammar.html#scanner
Contributor
Author
|
Rebased and added a patch to improve escape sequence handling in identifiers and URLs. |
Implement proper parsing of escape sequences in unquoted URL function arguments, and ensure escape sequences in quoted URLs are properly translated when creating a PropertyValuePart. The secondary parsing in PropertyValuePart to assign a type string can fail when the identifier contains escape sequences. Pass in a `hint` object based on the original token emitted from the lexer to disambiguate in these cases.
XhmikosR
added a commit
that referenced
this pull request
Feb 6, 2016
Properly parse CSS strings/URLs/identifiers with escape sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS escape syntax is not the same as JavaScript escapes -- and besides, using
evalis evil. Write a proper parser (and serializer) for CSS strings with escape sequences.