Allow matching functions as literals. #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/css/ValidationTypes.js
Outdated
| part.name === 'saturate' || | ||
| part.name === 'sepia'); | ||
| // custom() isn't actually in the spec | ||
| return ValidationTypes.isLiteral(part, "blur() | brightness() | contrast() | custom() | drop-shadow() | grayscale() | hue-rotate() | invert() | opacity() | saturate() | sepia()"); |
Member
There was a problem hiding this comment.
Maybe break this? Otherwise the patch looks good as far as I can tell.
I've updated several simple ValidationType functions to show how this can be used to simplify common matchers. It will also be used in a follow-up patch to validate the `font-variant-alternates` property which involves a large number of CSS function options.
cc7de2c to
7fcf5aa
Compare
XhmikosR
added a commit
that referenced
this pull request
Feb 5, 2016
Allow matching functions as literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated several simple
ValidationTypefunctions to show how this can be used to simplify common matchers. It will also be used in a follow-up patch to validate thefont-variant-alternatesproperty which involves a large number of CSS function options.