Use Matcher combinators to greatly simplify complex ValidationTypes
#199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows concise description of complex ValidationTypes, using syntax parallel to that in the official CSS specification. This patch just implements the mechanism; a follow-up patch uses it to simplify existing ValidationTypes.
As a side-effect, we also pushed handling the `inherit` option out of most ValidationTypes and moved it into the specification in the Properties table. I expect to refactor this further in the future to make handling of inherit/initial/unset automatic and implicit.
This was referenced Feb 5, 2016
XhmikosR
added a commit
that referenced
this pull request
Feb 6, 2016
Use `Matcher` combinators to greatly simplify complex `ValidationTypes`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows concise description of complex
ValidationTypes, using syntax parallel to that in the official CSS specification. The first patch just implements the mechanism; the second patch uses it to simplify existingValidationTypes.