Resolve fallback with all test cases #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 It'd be really nice if this fix lands. I've played with it a bit and it seems to work well. |
| } | ||
| } | ||
| }({}.hasOwnProperty); | ||
| } |
There was a problem hiding this comment.
What are you trying to support with this?
This polyfill doesn't seem necessary for Node v4+, https://kangax.github.io/compat-table/es6/#test-Object_static_methods
Better to pull in a separate package from npm if we actually do want this.
|
@marklu Feel free to resolve the conflicts and comments in a new PR 😀 |
|
Ok .. I will work on the changes and make a new PR ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #37
previous PR