Fixes #37 #48
Closed
Fixes #37 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return to; | ||
| }; | ||
| } |
There was a problem hiding this comment.
We already have extend for this type of thing, see
postcss-css-variables/index.js
Line 70 in ddb3b8b
| } | ||
|
|
||
| .box-bar { | ||
| width: var(--missing,calc(var(--foo1) + 100px)); |
There was a problem hiding this comment.
Let's space it out width: var(--missing, calc(var(--foo1) + 100px));
| .box-foo { | ||
| width: var(--missing); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are we getting rid of this?
| var fallbackValue; | ||
| if(fallback) { | ||
| var cloneDecl = Object.assign({},decl,{value:fallback}); | ||
| fallbackValue = resolveValue(cloneDecl, map, false,true).value; |
There was a problem hiding this comment.
Let's space this out (sorry no eslint)
var cloneDecl = Object.assign({}, decl, { value: fallback });
fallbackValue = resolveValue(cloneDecl, map, false, true).value;| // Set the new value after we are done dealing with at-rule stuff | ||
| decl.value = valueResults.value; | ||
| } | ||
|
|
There was a problem hiding this comment.
Rebase this onto the current master and squash things down. This is already in the codebase
MadLittleMods
requested changes
Mar 12, 2017
|
Thanks for the contribution. Closing in favor of #49 which seems to have the comments addressed and includes your commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Previous PR: #39