Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Adding in ESLint and fixing basic errors to match #104 #114

Merged
merged 1 commit into from
May 4, 2015
Merged

Adding in ESLint and fixing basic errors to match #104 #114

merged 1 commit into from
May 4, 2015

Conversation

jonathanKingston
Copy link
Contributor

No description provided.

@MoOx
Copy link
Owner

MoOx commented May 4, 2015

Very nice !

Can you also:

  • use a symlink for eslintignore (-> .gitignore)
  • remove all trace of jshint and jscs (.rc + package.json refs)

That would be very cool.

@jonathanKingston
Copy link
Contributor Author

Done.

  • Made the checks run the .gitignore like the jshint did before.
  • Removed the babel-eslint lines as just noise.
  • Removed mentions of jscs and jshint

@MoOx
Copy link
Owner

MoOx commented May 4, 2015

Awesome ! Thanks a lot.

MoOx added a commit that referenced this pull request May 4, 2015
@MoOx
Merge pull request #114 from jonathanKingston/eslint-integration
74b4b08 
Adding in ESLint and fixing basic errors to match #104
@MoOx MoOx merged commit 74b4b08 into MoOx:master May 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @MoOx